[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

WordPress Trac noreply at wordpress.org
Tue May 6 17:20:11 UTC 2014


#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 In [changeset:"28304"]:
 {{{
 #!CommitTicketReference repository="" revision="28304"
 In `wp-admin/includes/update.php`, remove dead code:

 * In `get_core_checksums()`, `$return` is set and never used.
 * In `core_update_footer()`, `break` is unnecessary and unreachable after
 `return`.
 * In `get_theme_updates()`, `$themes` is set and never used.
 * In `wp_theme_update_row()`, `$theme_name` is the only user of
 `$themes_allowedtags`... neither are used.

 See #27882.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list