[wp-trac] [WordPress Trac] #9547: Taxonomy - interesting 'unused' term_order column in table term_relationships.

[WordPress Trac]

#9547: Taxonomy - interesting 'unused' term_order column in table
term_relationships.
----------------------------------------+-----------------------------
 Reporter:  michelwppi                  |       Owner:  ryan
     Type:  enhancement                 |      Status:  reopened
 Priority:  high                        |   Milestone:  Future Release
Component:  Taxonomy                    |     Version:  2.8
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+-----------------------------

Comment (by simonwheatley):

 Replying to [comment:29 helen]:
 > Replying to [comment:28 nacin]:
 > > Should get_the_term_list() and the_terms() be converted from `$before
 = '', $sep = '', $after = '', $args = array()` to just `$args = array()`
 that contains `'before'`, `'sep'`, and `'after'`?
 >
 > My vote would be yes.

 Refreshing and so forth aside: how would you like to tackle this? I can
 see either:

 '''Option 1.''' Backwards compatibility: Check the third argument in
 `get_the_term_list()` and `the_terms()` to see if it's a string (treat the
 arguments as "legacy format", with the sixth argument as the `$args`
 array) and if the third argument is an array, assume the author is new
 school and interpret this as the `$args` argument.

 '''Option 2.''' New way or the highway: Check if the third argument is a
 string, and if it is then call `_doing_it_wrong` but otherwise just drop
 the argument.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/9547#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform