[wp-trac] [WordPress Trac] #24409: Edit Image in TinyMCE editor revamp

[WordPress Trac]

#24409: Edit Image in TinyMCE editor revamp
----------------------------+--------------------
 Reporter:  eablokker       |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Media           |     Version:  3.5.1
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+--------------------

Comment (by gcorne):

 Added attachment:24409-02.patch which includes the following improvements:

 * The “Replace Image” is now working.
 * Tweaked the design a bit so that it is less awkward.
 * Fixed an issue with the linkTo functionality when dealing with external
 images.
 * Fixed an issue where the linkTo url was being focused and selected
 causing the div to be scrolled down awkwardly when the viewport was not
 super tall.
 * Disabled the built-in tinymce image plugin.
 * Changed how the opening of the modal is triggered so that it works in IE

 I have the following on my todo list:

 * Add spinner and show if it takes longer than 2 seconds to fetch
 attachment if editing an attachment.
 * Explore using a different technique than a reference to the promise when
 waiting for the attachment to be fetched.
 * See how to best reuse templates and see what we can do about refactoring
 some of the  other stuff.
 * Consider doing some other refactoring to use composition and dependency
 injection to avoid the deep inheritance trees a bit.
 * Consider disabling or changing the label of the toolbar button when the
 image being replaced is selected.
 * Implement the edit and replace buttons in a similar fashion to 3.8, but
 with a new design (design is pending).
 * Remove old modal code from the wpeditimage plugin.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24409#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform