[wp-trac] [WordPress Trac] #26669: wp-admin.css should be broken up into modules
WordPress Trac
noreply at wordpress.org
Wed Feb 19 23:49:02 UTC 2014
#26669: wp-admin.css should be broken up into modules
----------------------------+---------------------
Reporter: jorbin | Owner: helen
Type: enhancement | Status: closed
Priority: normal | Milestone: 3.9
Component: Administration | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses: ui
----------------------------+---------------------
Comment (by helen):
Replying to [comment:21 johnjamesjacoby]:
> Having done some cursory testing with bbPress's green schemes, I'll sign
off that all appears a-okay. I'll create a new ticket if I see any
oddities. Nice work, Helen.
Thanks, glad to hear that things are looking okay. I readily admit that
(a) I got too excited about my commit message and just committing the
blasted thing and failed to make a plain English summary until later, and
(b) because this particular changeset only affects core development, I
didn't think to allay plugin/theme dev concerns with something so large
that you can't even view it. But trust me: this has zero impact on plugin
and theme development. :)
All the CSS changes move existing CSS into separated files and break up
the media queries so the cascade isn't broken. The Gruntfile.js changes
can be found in [attachment:26669-gruntfile.2.diff]. Finally, a few lines
were removed from `$_old_files`, because some newly created CSS files have
the same name as files that existed before the 3.3 merge, so we don't want
to copy the new files over and then have the install process just stupidly
delete them again (it's happened before). Happy to diff that file alone
for the curious. Here's what changed:
{{{
M Gruntfile.js
A + src/wp-admin/css/about.css
A + src/wp-admin/css/admin-menu.css
A + src/wp-admin/css/common.css
A + src/wp-admin/css/dashboard.css
A + src/wp-admin/css/edit.css
A + src/wp-admin/css/forms.css
A + src/wp-admin/css/l10n.css
A + src/wp-admin/css/list-tables.css
A + src/wp-admin/css/login.css
A + src/wp-admin/css/media.css
A + src/wp-admin/css/nav-menus.css
A + src/wp-admin/css/press-this.css
A + src/wp-admin/css/revisions.css
A + src/wp-admin/css/themes.css
A + src/wp-admin/css/widgets.css
M src/wp-admin/css/wp-admin.css
M src/wp-admin/includes/update-core.php
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26669#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list