[wp-trac] [WordPress Trac] #26669: wp-admin.css should be broken up into modules

WordPress Trac noreply at wordpress.org
Wed Feb 19 23:29:25 UTC 2014


#26669: wp-admin.css should be broken up into modules
----------------------------+---------------------
 Reporter:  jorbin          |       Owner:  helen
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:  3.9
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:  ui
----------------------------+---------------------

Comment (by johnjamesjacoby):

 Replying to [comment:20 jorbin]:
 > @import is just being used by wp-admin/css/wp-admin.css at this point
 and unless plugins are hacking core, I'm confused as to how this will
 affect them.  For people running without SCRIPT_DEBUG set to true, this
 creates zero change for them.
 The commit message (though clever, and quoting Children's Story is always
 appreciated) wasn't super clear (to me) about what was switched to using
 @import. After reading Helen's summary, it wasn't much more clear what the
 impact would be for plugins that include their own color schemes --
 something that has been historically difficult (see: almost impossible
 without including your own image assets, and without pulling in colors-
 fresh for 3.8.)

 Showing compassion for plugin developers that want to do good and ensure
 limited/no breakage (especially when 200k line changesets come in) goes a
 long way towards keeping up-stream contributions flowing in. I'm hoping
 the next time someone asks a similar question, it's met with a more
 positive and helpful response.

 Having done some cursory testing with bbPress's green schemes, I'll sign
 off that all appears a-okay. I'll create a new ticket if I see any
 oddities. Nice work, Helen.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26669#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list