[wp-trac] [WordPress Trac] #25419: Add icon support for widgets on the admin page and customize screens

[WordPress Trac]

#25419: Add icon support for widgets on the admin page and customize screens
-------------------------------------+---------------------------------
 Reporter:  westonruter              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Widgets                  |     Version:  3.9
 Severity:  minor                    |  Resolution:
 Keywords:  ui-feedback needs-patch  |     Focuses:  ui, administration
-------------------------------------+---------------------------------

Comment (by eherman24):

 ocean90, thanks for the feedback.

 I guess I wasn't sure about the minified files being re-compiled, but
 thanks for the clarification. In regards to backwards compatibility, what
 I have appears to work in regards to previous version of WordPress.

 Pre-patch, the constructor passes in the $option->name (string) in that
 argument location. With the new patch, I'm passing in an array and
 checking if the returned argument is indeed an array. Is this not a viable
 way to go about doing things? I tested against previous versions of
 WordPress and things appeared to be backwards compatible with the new
 patch.

 `$this->icon_url = is_array($icon_url) || empty($icon_url) ? '' :
 $icon_url; // create the icon url parameter `

 And noted on the white space, I'll have a second go at this and fix the
 issues you have pointed out.

 Thanks,
 Evan

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25419#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform