[wp-trac] [WordPress Trac] #25419: Add icon support for widgets on the admin page and customize screens
WordPress Trac
noreply at wordpress.org
Thu Aug 14 17:11:48 UTC 2014
#25419: Add icon support for widgets on the admin page and customize screens
-------------------------------------+---------------------------------
Reporter: westonruter | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Widgets | Version: 3.9
Severity: minor | Resolution:
Keywords: ui-feedback needs-patch | Focuses: ui, administration
-------------------------------------+---------------------------------
Changes (by ocean90):
* keywords:
ui-feedback has-patch dev-feedback needs-testing needs-docs 2nd-
opinion
=> ui-feedback needs-patch
Comment:
eherman24, thanks for your patch so far. Some feedback:
* No need to patch minified files, these are auto-generated on build
* We don't use `filter_var()` in core, you can use `esc_url()` instead
* The constructor shouldn't get new arguments, as this breaks backward
compatibility
* Some whitespace mistakes, see http://make.wordpress.org/core/handbook
/coding-standards/php/#space-usage
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25419#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list