[wp-trac] [WordPress Trac] #24813: wp_add_inline_style behaviour changes with SCRIPT_DEBUG

WordPress Trac noreply at wordpress.org
Tue Oct 8 19:26:07 UTC 2013


#24813: wp_add_inline_style behaviour changes with SCRIPT_DEBUG
------------------------------+-----------------------------
 Reporter:  stephenharris     |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  3.7
Component:  General           |     Version:  3.3
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+-----------------------------

Comment (by stephenharris):

 Replying to [comment:10 georgestephanis]:
 > And for that matter, if the expectation is that they are passing in
 something already wrapped in <style> tags, then why do we have
 [http://core.trac.wordpress.org/browser/tags/3.5.2/wp-includes/class.wp-
 styles.php#L123 this bit that wraps it in the output function?]

 Indeed, but there is a return before its wrapped in `<style>` tags, and
 when that second argument of `print_inline_style()` is set to `false`, as
 is (sometimes) done by `$wp_styles->do_item()` you get an inconsistent
 behaviour.

 On a production site (`SCRIPT_DEBUG == false` it therefore behaves
 differently depending on whether your admin-side or front-end ).

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24813#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list