[wp-trac] [WordPress Trac] #24813: wp_add_inline_style behaviour changes with SCRIPT_DEBUG

[WordPress Trac]

#24813: wp_add_inline_style behaviour changes with SCRIPT_DEBUG
------------------------------+-----------------------------
 Reporter:  stephenharris     |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  3.7
Component:  General           |     Version:  3.3
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+-----------------------------

Comment (by stephenharris):

 The patch was intended to modify behaviour when `SCRIPT_DEBUG == true` (as
 this sets `$wp_scripts->do_concat` to `false`). That way production sites
 would be unaffected, and the function would behave consistently.

 What I've only just realised on revisiting this is that `!is_admin()`
 ''also'' `$wp_scripts->do_concat` set to `false`.

 (`$wp_scripts->do_concat` is set by `global $concatenate_scripts`, itself
 set here https://github.com/WordPress/WordPress/blob/master/wp-includes
 /script-loader.php#L902.)

 In light of that the above issue still stands admin-side, but the attached
 patch isn't recommendable.

 @georgestephanis' suggestion of checking for `<style>` tags is probably
 the best way forward.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24813#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software