[wp-trac] [WordPress Trac] #24622: If-Modified-Since is wrong by comment feed

[WordPress Trac]

#24622: If-Modified-Since is wrong by comment feed
--------------------------------------------------+--------------------
 Reporter:  sweetie089                            |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  3.7
Component:  Feeds                                 |     Version:  1.5.1
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch 3.7-early needs-unit-tests  |
--------------------------------------------------+--------------------
Changes (by nacin):

 * keywords:  has-patch 3.7-early => has-patch 3.7-early needs-unit-tests


Comment:

 Looking at this again, I actually think the logic in and location of the
 first patch was closer to ideal than the second patch.

 WP_Query specifically sets withcomments to 1 if the feed query variable
 contains comments-, even if withoutcomments is set. It overrides
 withoutcomments, which is only consulted when withcomments is not
 specified and we are dealing with a singular item.

 So, the logic needs to be moved up a bit, to ensure the behavior is the
 same.

 I don't think there is any unit tests here; that would be good to have in
 the future.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24622#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software