[wp-trac] [WordPress Trac] #24622: If-Modified-Since is wrong by comment feed

[WordPress Trac]

#24622: If-Modified-Since is wrong by comment feed
---------------------------------+--------------------
 Reporter:  sweetie089           |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  3.7
Component:  Feeds                |     Version:  1.5.1
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.7-early  |
---------------------------------+--------------------

Comment (by nacin):

 So it seems like that block from WP_Query actually needs to be moved
 entirely into the WP class. Is there even a reason to have that in
 WP_Query, other than for direct use of WP_Query for preparing a comments
 feed *without* using withcomments? (Fine with keeping it, just want to
 make sure we look at it from all angles.)

 Because of the block in WP_Query, we should use the same logic in the WP
 class. If `comments-*`, strip it and set withcomments.

 Is this easily unit testable? That would be nice.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24622#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software