[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core

[WordPress Trac]

#25858: Integrate MP6 into core
----------------------------+------------------
 Reporter:  dd32            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by iammattthomas):

 Updated the widgets patch:

 > * Vastly different CSS structure than is used elsewhere in core, and in
 other MP6 patches (super-indenting each subsequent "nested" rule)

 I've cleaned this up and reinstated "normal" nesting of rules, no super-
 indenting.

 > * Would've been nice if this CSS was modified in-place rather than being
 copy-pasted into a new block, makes it rather hard to review what actually
 changed, for example, I can see that `.widget_title h4` is mostly the
 same, but it moved for no reason, etc.

 I looked into this a bit, but it seems like an attempt was made to more
 logically organize the CSS along with the changes that were made. While it
 makes reviewing this diff a bit more difficult, I think the organization
 makes sense.

 > * Colours need moving to colour stylesheets, no need to `!important` it
 here
 > * There's so much new CSS here it seems, that splitting it into it's own
 file is fast approaching, it's 1,000 lines of altered CSS atm.

 Going to leave these two for post-merge fixes if there are no objections.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:34>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software