[wp-trac] [WordPress Trac] #25858: Integrate MP6 into core

[WordPress Trac]

#25858: Integrate MP6 into core
----------------------------+------------------
 Reporter:  dd32            |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.8
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by ryelle):

 Some quick fixes in [attachment:25858.colors.3.diff]
 > * .icon-dashicon & the dashicon() mixin is un-used, unreferenced styles
 in core and doesn't appear to be used by the patch
 I think it might be worth having dashicon classes in core, but this isn't
 the place for that- this has been removed.
 > * `src/wp-admin/includes/ajax-actions.php` needs cleaning up, error_log
 removal, nonce protection, cap checks to see if the current user can edit
 a user, questions on if we should even support changing another users
 colour scheme
 Agreed. Removed error_log, more cleanup to come. I think you've always
 been able to change another user's color scheme, but the autosave here
 might make that dangerous (unexpected).
 > * docblock for `wp_admin_css_color()` needs updating with correct
 variable name, can probably convert that array( ..) to a compact() instead
 (would require renaming `$icon_colors`)
 Fixed the docblock name.
 > * `.picker-dropdown` in `admin_color_scheme_picker()` HTML appears to be
 indented an extra tab, should also use the `selected()` helper, and
 `esc_url()` for URL escaping (instead of `esc_attr()`)
 The 'selected' code is just for a class, so `selected()` isn't appropriate
 here. I've updated the escaping for the URL to use `esc_url`.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25858#comment:33>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software