[wp-trac] [WordPress Trac] #24317: Custom Taxonomy Overview page gives wrong "Filter Posts by Term" URL parameter

[WordPress Trac]

#24317: Custom Taxonomy Overview page gives wrong "Filter Posts by Term" URL
parameter
--------------------------+------------------------------
 Reporter:  tar.gz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by tar.gz):

 In that patch, I identified the place where we need to fix the link
 parameters.

 If we have this: `$args = array( $tax->query_var => $tag->slug );`
 then we end up with the non-working `edit.php?foo=bar`

 If we write it like `$args = array( 'taxonomy' => $tax->name, 'term' =>
 $tag->slug );`
 we get what we want: `edit.php?taxonomy=foo&term=bar`

 However, this change also effects the ordinary Tags and Categories, where
 the parameters now change from this : edit.php?`tag=my_tag_term`
 to this: `edit.php?taxonomy=post_tag&term=my_tag_term`

 Which also works fine - so maybe it's a non-issue, or even an improvement.

 Anyhow, I have no idea what the condition `if ( $tax->query_var )` is
 supposed to check.

 So, please, somebody review my rudimentary patch :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24317#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software