[wp-trac] [WordPress Trac] #24202: Self-explanatory argument values for new media functions

WordPress Trac noreply at wordpress.org
Sun May 5 11:46:49 UTC 2013


#24202: Self-explanatory argument values for new media functions
------------------------------------------------+--------------------
 Reporter:  SergeyBiryukov                      |       Owner:
     Type:  enhancement                         |      Status:  new
 Priority:  normal                              |   Milestone:  3.6
Component:  Media                               |     Version:  trunk
 Severity:  normal                              |  Resolution:
 Keywords:  dev-feedback 2nd-opinion has-patch  |
------------------------------------------------+--------------------

Comment (by kovshenin):

 [attachment:24202.3.diff] builds off of Drew's patch:
 * `$content` is an argument of its own (again) passed by reference
 * Renamed the arguments back to their original values to avoid confusion
 (for now)
 * Looked through all usage of affected functions, .2 was missing a couple
 * Added more docblocks, rewrote `$args` docblocks to look more like what
 we use in `register_post_type` etc.
 * Removed trailing spaces, added trailing commas in multiline arrays

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/24202#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list