[wp-trac] [WordPress Trac] #24202: Self-explanatory argument values for new media functions
WordPress Trac
noreply at wordpress.org
Fri May 3 16:21:31 UTC 2013
#24202: Self-explanatory argument values for new media functions
------------------------------------------------+--------------------
Reporter: SergeyBiryukov | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.6
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: dev-feedback 2nd-opinion has-patch |
------------------------------------------------+--------------------
Comment (by DrewAPicture):
Replying to [comment:7 kovshenin]:
> We should consider leaving `$content` as a separate argument, passed by
reference by default, and an `$args` array with everything else. Thoughts?
I think that makes good sense. I'd considered leaving the `type` param out
of the array but it seemed to be a good fit when grouped with the other
args.
Now that I look back on it, passing `$content` whether by reference or not
-- as an arg -- seems odd. If it would simplify things leaving it out of
the array, +1
--
Ticket URL: <http://core.trac.wordpress.org/ticket/24202#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list