[wp-trac] [WordPress Trac] #24736: Revisions: IE compatibilty

[WordPress Trac]

#24736: Revisions: IE compatibilty
--------------------------+--------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+--------------------

Comment (by markjaquith):

 So, tooltips were misaligned. The math was just wrong. And it wasn't ever
 going to work, due to the way browsers have to make sacrifices to fit
 items into a pixel grid. Turns out adamsilverstein partially had the right
 idea earlier, when he was pixel-aligning the tooltips. That's how it
 should be done, because otherwise it's always going to be janky.

 Additionally, the way tooltips and tickmarks were done for RTL was... odd.
 It rendered the tick marks LTR, and did lots of backflips in the JS.

 One problem is that the slider doesn't have an RTL mode. So the values and
 the handles are always going to be the same. So '''some''' amount of
 backflips are necessary, say then setting or reading from the slider.

 So [attachment: 24736.10.patch] changes some stuff around:

 Building on .7.patch, it makes it so that the tick marks use the tooltips
 model as its model. It then can communicate the '''exact''' pixel position
 of a particular tickmark when the hovered revision changes. The tooltip
 can that read that, and align itself.

 I also removed a lot of the unnecessary and complicated RTL backflips by
 making the tick marks flow RTL in RTL mode.

 Still chasing down one last issue in Firefox RTL.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24736#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software