[wp-trac] [WordPress Trac] #22839: Spinners don't show up in .sidebar-name

[WordPress Trac]

#22839: Spinners don't show up in .sidebar-name
-------------------------------------+------------------------------
 Reporter:  cdog                     |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Administration           |     Version:  3.4.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------

Comment (by cdog):

 Currently, spinners are toggled via .show()/.hide() jQuery methods. But
 this doesn't seem to work in all cases creating some inconsistencies
 (mainly when floats are used).

 attachment:22839.2.diff introduces the .active class which toggles a
 spinner when added/removed. The main advantage is that it adds a standard
 way of toggling a spinner. Another advatage of adding/romoving a class is
 that it allows more than one property (not only the display property) to
 get toggled at once if it's needed.

 In Quick Edit mode, the spinner seems to have an unnecessary offset of
 10px (removed in patch).

 Also found that the #major-publishing-actions .spinner never shows up when
 editing an attachment (with or without the patch applied) like it does
 when editing a post.

 Steps to reproduce:

 1. In Dashboard, go to Media > Libary.
 2. Select an image.
 3. Press Update.

 This particular spinner (from #submitpost) is toggled only in wp-
 includes/js/autosave.js which is not loaded when editing an attachment.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22839#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software