[wp-trac] [WordPress Trac] #21195: get_avatar_url

[WordPress Trac]

#21195: get_avatar_url
-----------------------------+------------------------------
 Reporter:  pathawks         |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  General          |     Version:  2.5
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------------------

Comment (by pathawks):

 Replying to [comment:17 cliffseal]:
 > Replying to [comment:16 pathawks]:
 > > Of course it doesn't; you're working with a modified version of
 `get_avatar` :)
 > Just to be super clear here: no, I'm not. I kept the current version of
 get_avatar in pluggable.php and overrode it in a plugin for testing.

 Sorry, should have been more clear. WordPress is using a modified version
 of `get_avatar`, at any rate.

 > It would seem any decent plugin author would check for this error before
 proceeding.
 If that's the case, then what would be the point in changing things?
 If I will have to, not only provide a way to extract the URL from the
 returned `<img>` tag in these circumstances, but also check to see if the
 output from `get_avatar` is a URL or a tag, we actually end up with far
 more code than what we would currently need.

 No, it seems that, if anything changes, a new function should be added
 called `get_avatar_url` or whatever, and `get_avatar` should be left
 alone. I see absolutely no advantage from trying to shim totally different
 functionality into an existing function, which currently does it's job
 well enough.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21195#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software