[wp-trac] [WordPress Trac] #26334: Disable 'Featured Plugins' if they're included in Core

[WordPress Trac]

#26334: Disable 'Featured Plugins' if they're included in Core
-----------------------------+--------------------
 Reporter:  Ipstenu          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.8
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by azaozz):

 Tend to agree with @markoheijnen, core shouldn't be dealing with plugin
 fixes. On the other hand, knowingly letting an upgrade to 3.8 crash and
 burn is not acceptable either.

 All feature plugins should *always* start with something like this:

 {{{
 global $wp_version;

 if ( empty( $wp_version ) )
   exit;

 if ( version_compare( $wp_version, '3.8', '>=' ) ) // or 3.9, 4.0
   return;
 }}}

 Unfortunately neither of the three merged plugins has that.

 A few things can be done:
 1. Update the three plugins and add the above snippet.
 2. (Maybe) In the 3.8 "upgrade" message, include a reminder to turn off
 these plugins before upgrading.
 3. As far as I see only DASH causes fatal errors. It seems it used
 `dashboard` as prefix but the functions weren't renamed on merging with
 core (it also used the `wp_` prefix which should never happen in a
 plugin...). Rename the offending functions in core:
  - `wp_dashboard_activity()`
  - `dashboard_show_published_posts()`
  - `dashboard_comments()`
  - `dashboard_relative_date()`

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26334#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software