[wp-trac] [WordPress Trac] #26334: Disable 'Featured Plugins' if they're included in Core

WordPress Trac noreply at wordpress.org
Sun Dec 1 23:07:22 UTC 2013


#26334: Disable 'Featured Plugins' if they're included in Core
-----------------------------+--------------------
 Reporter:  Ipstenu          |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.8
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by dd32):

 > I also don't see why we should care much if users don't upgrade their
 plugin first before core. We also didn't care when we introduced
 has_shortcode().

 I don't think not doing it in the past is an excuse not to do it now.
 We definitely can't stop someone from re-activating it (well, we can, but
 shouldn't), but we can prevent an unexpected issue upon upgrade - we
 should be aiming for our upgrades to never break anything.

 This would serve more than just fatal error protection though, It'll
 prevent bug reports from anyone running 3.8+MP6 for example, those people
 who left it enabled not realising they needed to disable it, "X is broken,
 it's displaying the wrong image, or has the wrong colour", etc.

 Ultimately, this is as simple as `deactivate_plugins( array( 'plugin-slug
 /plugin-slug.php', 'plugin-two.php' ), true, true );` in `upgrade_380()`

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26334#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list