[wp-trac] [WordPress Trac] #20651: Inconsistent MS API: delete_site_option action hook is only called AFTER deletion, unlike delete_option
WordPress Trac
noreply at wordpress.org
Thu Aug 22 22:52:58 UTC 2013
#20651: Inconsistent MS API: delete_site_option action hook is only called AFTER
deletion, unlike delete_option
------------------------------------+--------------------
Reporter: danielnashnz | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.7
Component: Multisite | Version: 3.3.2
Severity: normal | Resolution:
Keywords: dev-feedback has-patch |
------------------------------------+--------------------
Comment (by jeremyfelt):
Beyond pattern, the weird parts here are:
1. `pre_site_delete_option_$option` runs even if `delete_site_option()` is
run in single site mode.
1. The value of `$option` is required in advance to use
`pre_site_delete_option_$option`
I think a patch is worth it to fix at least the pass of `$option` to the
action, which is the original description of this ticket. See
[attachment:20651.4.diff]
In the long run, I think Nacin's option 2 is probably best. In some ways I
find the pattern of the hooks in the site_option functions to be more
intuitive.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20651#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list