[wp-trac] [WordPress Trac] #20651: Inconsistent MS API: delete_site_option action hook is only called AFTER deletion, unlike delete_option

WordPress Trac noreply at wordpress.org
Thu Aug 22 21:05:25 UTC 2013


#20651: Inconsistent MS API: delete_site_option action hook is only called AFTER
deletion, unlike delete_option
------------------------------------+--------------------
 Reporter:  danielnashnz            |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.7
Component:  Multisite               |     Version:  3.3.2
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+--------------------

Comment (by nacin):

 Option 1:

  * I wonder if we could just break things slightly here, move the
 delete_site_option hook to be a pre-delete hook, introduce a new
 deleted_site_option hook, and just ignore that
 pre_delete_site_option_$option exists.

 Option 2:

  * This isn't just in delete_site_option(). The same pattern exists in the
 other site_option() functions. While this pattern differs from the regular
 option() functions, it is at least consistent across the site_option API.
 Maybe wontfix? If/when we rename these to network_option we could use the
 other hook pattern.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20651#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list