[wp-trac] [WordPress Trac] #25023: WordPress 3.6 deleting data on custom post meta

[WordPress Trac]

#25023: WordPress 3.6 deleting data on custom post meta
---------------------------------------+------------------------------
 Reporter:  cdwharton                  |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  General                    |     Version:  3.6
 Severity:  critical                   |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------------

Comment (by cdwharton):

 Replying to [comment:7 helen]:
 > Replying to [comment:5 cdwharton]:
 > > Is there a simple check I can make on the function to check if its
 blank on initial load to just ignore until "Publish" is hit?
 >
 > You need a nonce field and to check the nonce before continuing on in
 your save_post callback.
 >
 > > Is there a better way to add custom meta boxes than the example I have
 provided?
 >
 > In this particular example, I am wondering why you don't use the
 excerpt. There are also a few things that should be changed, but Trac is
 not really the place for a non-core code review.

 Thanks Helen, I'm not using excerpt as its a page not a post and that it
 would confuse the end user (trust me it would). I'm not after a code
 review necessarily, what I am looking for is for someone to tell me why
 the data is being deleted since upgrading to WP 3.6. If its because I'm
 not using a nonce field then that's fine - I will implement that.

 The code I have used is readily available as you search the internet and
 its been working for me for a couple of years now. My concern is not only
 for myself and my clients that upgrade to 3.6 but other theme authors out
 there who use the same technique which up to this point seemed solid.

 Is there going to be an investigation into the cause of the data deletion,
 because it is happening and I can reproduce the bug?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25023#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software