[wp-trac] [WordPress Trac] #23901: Revisions: revisions.js clean up

[WordPress Trac]

#23901: Revisions: revisions.js clean up
--------------------------+--------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:21 adamsilverstein]:
 > please test your data with [attachment:23901.7.diff​ 23901.7.diff​], it
 should fix the issues you describe :)
 >
 >
 > Replying to [comment:18 azaozz]:
 > > Replying to [comment:17 adamsilverstein]:
 > > > is the id of the revision correct? that is, when you click the 'view
 the autosave' link, is the id in the link url the same as the stored
 autosave?
 > >
 > > Yes, it's the correct post ID.
 > >
 > > > it almost seems like the comparison direction left/right is
 reversed? might it be an ordering issue with the list of revisions ( ala
 #23923 )? would be interesting to see if changing the ordering to ID fixes
 this.
 > >
 > > No, changing the sorting doesn't seem to fix it. There are 6 revisions
 on the post, one is autosave:
 > >
 > > || ID   || post_author || post_name        ||
 > > || 9298 ||      4      || 9289-revision-v1 ||
 > > || 9297 ||      1      || 9289-revision-v1 ||
 > > || 9296 ||      4      || 9289-revision-v1 ||
 > > || 9295 ||      1      || 9289-revision-v1 ||
 > > || 9294 ||      1      || 9289-autosave-v1 ||
 > > || 9290 ||      4      || 9289-revision-v1 ||
 > >
 > > Usually autosaves are not the latest revisions as they get updated
 while the user is editing. Revisions are never updated.
 > >
 > > Also noticing we don't show the autosave(s) when listing the revisions
 in the Revisions postbox. In some cases there may be many autosaves (for
 different users) and no revisions.  All autosaves should be listed there
 imho, why have them if we don't tell the user he can restore?



 actually, please use [attachment:23901.8.diff​ 23901.8.diff​]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23901#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software