[wp-trac] [WordPress Trac] #16539: Duplicate search widgets cause ID conflicts

[WordPress Trac]

#16539: Duplicate search widgets cause ID conflicts
--------------------------+---------------------
 Reporter:  solarissmoke  |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  3.6
Component:  Widgets       |     Version:  3.0
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by WraithKenny):

 What are the chances that a child-themer noticed and deliberately targeted
 those non-unique ids against all common sense and best practice rules?
 When I trying to child-theme TwentyEleven, I noticed the error, which led
 me to this ticket in the first place. Core's error doesn't cause themer's
 to make errors but it certainly could be inspiring them to. It sets a
 terrible example.

 You missed that the Jaws7/IE6 issue is for removing the id/for linkage.
 (It's easily solved by adding a title attr.) That's what my links point
 to. It has nothing to do with the issue of Duplicated IDs.

 #23868 is my ticket heavily commented by me so of course I've read it.
 There's no evidence that a single child-theme would "break."

 You'd have to find one
  1. that didn't copy the searchform.php and
  2. that didn't inherit the parent's style.css and
  3. then chose to deliberately target non-unique ids. (even tho it isn't
 based on the parent's css)

 Does one theme like this even exist? Can we get a screenshot of just how
 "Severe" that "breakage" truly is? Out of your "tons" of themes, most will
 not be affected, and none severely.

 The css is truly absolutely insignificantly trivial. "ZOMG! My second
 little search box's blue border reverted to grey! End of World!" said no
 one ever.

 This isn't any kind of "regression" at all. At most it reveals a css error
 that is there with or without this fix. This doesn't *cause* a bug, it
 merely stops hiding it.

 On that last part, your right. At least sites wishing to fix this bug can
 open up their functions.php file, add the filter and set about fixing the
 css themselves. If they even notice.

 This revert also means that TwentyTen and TwentyTwelve are back to being
 invalid (see http://www.w3.org/TR/WCAG20-TECHS/F77.html ).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16539#comment:71>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software