[wp-trac] [WordPress Trac] #16539: Duplicate search widgets cause ID conflicts
WordPress Trac
noreply at wordpress.org
Fri Apr 5 00:51:38 UTC 2013
#16539: Duplicate search widgets cause ID conflicts
--------------------------+---------------------
Reporter: solarissmoke | Owner: azaozz
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 3.6
Component: Widgets | Version: 3.0
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Comment (by bpetty):
Replying to [comment:66 WraithKenny]:
> What here suggests that Jaws wasn't broken in 3.5?
If you're saying that it is broken (due to duplicate IDs), it really
doesn't matter anyway because then the choice is either between that, or
breaking CSS/JS compat with themes/plugins with incrementing IDs. And
between those two, it still makes sense to stick with duplicate IDs
because from what I gathered in your links and info is that it's not only
just older Jaws, but also only IE6. However, incrementing IDs to fix just
that would break CSS/JS in all browsers on those same pages that output
two search forms for everyone.
It sucks, but in that situation, it's pretty clear that compatibility has
to come before accessibility. That's partially our own fault for adding
the IDs in the first place that put us in this situation, but it's also
Jaws fault for leaving a bug in their software too (which they supposedly
have fixed already anyway).
By the way, if you looked at #23868, you'd see that breaking the CSS is
not really "trivial" since even the default themes that shipped with WP
made this mistake. So we're not only talking about themes, but also tons
of child themes too.
Leaving the duplicate IDs in there is just taking the less crappy road not
only for the reasons above, but also because regressions really are worse
than something that never worked in the first place. We've handled
"compliance" by providing the alternative HTML5 version that doesn't use
duplicate IDs. In doing so, we've also provided a "fix" for this ticket -
use HTML5.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16539#comment:70>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list