[wp-trac] [WordPress Trac] #20778: get_temp_dir should use the system tmp directory as first choice
WordPress Trac
wp-trac at lists.automattic.com
Wed Sep 26 23:58:29 UTC 2012
#20778: get_temp_dir should use the system tmp directory as first choice
------------------------------+---------------------
Reporter: simonwheatley | Owner: dd32
Type: enhancement | Status: closed
Priority: normal | Milestone: 3.5
Component: Filesystem | Version: 2.5
Severity: normal | Resolution: fixed
Keywords: has-patch commit |
------------------------------+---------------------
Comment (by dd32):
> Looks like this is only happening because the test in question is
realpath()ing the result.
That sounds like something that someone would do to work around symlinks
or something.
I'll also note this here, I am somewhat unconvinced that we *actually*
need to use `win_is_writable()` at all in core, however, I'm unsure of the
latest PHP version which is affected by the bugs which require it's use (I
would not be surprised if PHP 5.2 is affected, while 5.3/5.4 are not).
Since this change means that a system directory outside of the normal web
directories may be used, I thought it was the safest bet to use
`win_is_writable()` to prevent any edge cases. A new ticket will need to
circle back on it, but I'd really like to define the conditions which make
it needed.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20778#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list