[wp-trac] [WordPress Trac] #22080: add_theme_support should merge post-thumbnail post types by default (currently stomps)

WordPress Trac wp-trac at lists.automattic.com
Wed Oct 3 22:45:14 UTC 2012


#22080: add_theme_support should merge post-thumbnail post types by default
(currently stomps)
-----------------------------------+------------------------------
 Reporter:  alexkingorg            |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Post Thumbnails        |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------

Comment (by alexkingorg):

 Ok, I'm reading this as: please revise the patch as follows:

 - no "stomp/replace" param (actually makes things simpler)
 - add matching functionality to be able to remove post-thumbnails on a per
 post-type basis

 I generally agree and will proceed with those changes.

 The only edge case I can think of is someone trying to explicitly remove
 support for post-thumbnails from a specific post type when a blanket
 "support it for all post types" has been set. I'm leaning towards that
 "doing nothing" and returning an error/false-ish response. Anyone else
 have a good idea for this situation?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22080#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list