[wp-trac] [WordPress Trac] #22080: add_theme_support should merge post-thumbnail post types by default (currently stomps)

[WordPress Trac]

#22080: add_theme_support should merge post-thumbnail post types by default
(currently stomps)
-----------------------------------+------------------------------
 Reporter:  alexkingorg            |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Post Thumbnails        |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------

Comment (by nacin):

 I doubt that a "no stomp" argument is necessary.

 The function is "add", not "set". If you want to remove, you should call
 remove. We've been careful to merge arguments for other theme support
 arguments (namely, custom headers and backgrounds), so this patch would
 make things consistent.

 It would make sense that when doing this, remove_theme_support() is
 updated to handle removing individual post types.

 scribu: You need to support it in two places because just because the post
 type supports thumbnails for a type, doesn't mean the theme does.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22080#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software