[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by nacin):

 > I'm not that familiar with licensing, so my question is maybe more about
 that - is it okay to modify the source code of that library? What is the
 downside of doing that?

 From a licensing perspective, yes. From a maintenance perspective, we try
 not to. And when we do, we carefully consider why, and even then, we try
 to float the patch upstream.

 > So you don't think it would be a problem to refactor that library / ie:
 alter the source code? (it could use some rehabilitation IMHO)

 This library has seen better days. I would not be comfortable including it
 in core in its current state, unless it receives an audit, at the very
 least.

 Doing some research, it looks like ImageMagick supports creating ICO
 files. We should probably just use Imagick if it exists, and fallback to
 PNG-only if it does not. Here's some stuff on php.net
 [http://www.php.net/manual/en/imagick.flattenimages.php on ICO to PNG],
 for example.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:85>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software