[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------------------+------------------
 Reporter:  jane                                 |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  3.4
Component:  Administration                       |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing ux-feedback  |
-------------------------------------------------+------------------

Comment (by nacin):

 The Filesystem API doesn't fit here. If we can't take an uploaded PNG and
 write out ICO, we use the PNG. This is the uploads directory — If we can
 upload the PNG, we can likely write the ICO to the same place. (The
 library *could* use an is_writeable() check, and/or some sort of error
 handling or suppression on the fopen(), but we can let it slide during
 testing.)

 The Filesystem API is only designed for critical tasks. Updates, installs.
 Things like uploads are not critical and therefore avoid the filesystem
 API. It's also why permissions are going to be more lax on the uploads
 directory in many cases, because we need to be able to write files here in
 a normal process, rather than asking for your FTP credentials. (Not even
 sure how that'd work anyway.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:84>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software