[wp-trac] [WordPress Trac] #20074: Attempt MD5 checksum verification in upgrader if available

[WordPress Trac]

#20074: Attempt MD5 checksum verification in upgrader if available
------------------------------------+------------------
 Reporter:  sivel                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.4
Component:  Upgrade/Install         |     Version:  2.8
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by sivel):

 If we did the verification within download_url(), we would have to add an
 arg to specify whether or not we want to perform the verification, perhaps
 defaulted to false.  Although as I think about it, I'm not sure why you
 wouldn't want to verify if it was available, so perhaps defaulted to true.
 This may actually help those who use download_url(), so that they don't
 have to re-implement the verification code. I kind of like this.

 In either case, I'd still like to be able to get the full response back
 from download_url(), whether in the return or as a reference. Although for
 me, assigning the response by reference feels a little odd.  We don't do
 this often as it is, and could perhaps not be clear to people trying to
 use it.

 I'll update the patch, based on feedback, if we want to move in one or
 more of those directions.

 And for what it is worth, and as a side note, I am pretty much finished on
 the code to add Content-MD5 to nginx via the embedded perl module.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20074#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software