[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General
WordPress Trac
wp-trac at lists.automattic.com
Thu Feb 16 22:35:07 UTC 2012
#16434: Give site admin ability to upload favicon in Settings, General
-----------------------------+------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.4
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: |
-----------------------------+------------------
Comment (by TomAuger):
Working on a non-AJAX implementation first. The UI is trickier than it
first appears. If we avoid the right-hand metabox that is used on the .com
blavatar implementation, we get into a collision with the Settings >
General form - that is, we need a multipart form to handle the file
upload, but you can't nest forms.
Options:
1. Use the metabox after all so its form can live in its own section of
the HTML code
2. Put the upload / favicon option above or below the other General
options so it can have a different form
3. Put it inside the General settings form, change that form to use
multipart, and do the file processing within the code that handles the
updating of the general options. I like this approach the least since it
could really get messy, and it isn't immediately obvious to the user that
clicking "upload" button would also save any other settings they may have
accidentally messed with in the Options.
For the time being, putting it on the top of the form (option #2) seems
like the easiest approach, but is that giving the favicon too much
importance?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:54>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list