[wp-trac] [WordPress Trac] #19200: Introduce themes_url() and upload_url()

WordPress Trac wp-trac at lists.automattic.com
Wed Nov 9 17:10:02 UTC 2011


#19200: Introduce themes_url() and upload_url()
-------------------------+------------------------------
 Reporter:  ramiy        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by scribu):

 I don't think this is check is appropriate here:

 {{{
 if ( 0 === strpos($url, 'http') && is_ssl() )
   $url = str_replace( 'http://', 'https://', $url );
 }}}

 Instead, we should make wp_upload_dir() use site_url().

 Also, you have some missing whitespace around function calls.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19200#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list