[wp-trac] [WordPress Trac] #16365: Comment transition for new comments

[WordPress Trac]

#16365: Comment transition for new comments
-------------------------+-----------------------------
 Reporter:  MattyRob     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Comments     |     Version:  3.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------------

Comment (by MattyRob):

 Replying to [comment:8 nacin]:
 > Replying to [comment:7 MattyRob]:
 > > I know the core devs are busy but honestly when someone contributes
 code that improves the core you really know how to ignore people on here!
 >
 > This is one of more than two thousand tickets. I alone make somewhere
 around 600 comments a month to Trac. It's not like I'm deliberately
 avoiding your patches.

 As I said - I know you are busy and this was not a personal attack on you.
 But, this ticket was commented on when it was new, moved from pending
 review to future release and noted as 'seems reasonable' - and then
 apparently ignored!

 > Yes, actually. There's at least three different comment.php files. Which
 one is this? I'm not inclined to guess. Diff from the root, rather than
 from the directory.
 >
 > So here's why I said maybe regarding 3.3, and definite no regarding 3.2:
 I'm not sure I like it. wp_transition_comment_status() is for
 transitioning a comment status from one to another, not for the comment
 creation to begin with. This might cause backwards compatibility issues
 due to the generic hooks in wp_transition_comment_status(). It should
 possibly be a new hook.

 So are you saying you don't think this is reasonable? The is a
 new_to_{new_status} hook for posts already in core - has been for ages. I
 cannot imagine of a scenario where this might cause an issue.

 But, hey I'm all ears. If this doesn't get committed I will not be able to
 add a new feature to my plugin because I'm certainly not going to write
 reams of code to check comment transition status from 'new' to approved
 when I can already simply hook into unapproved to approved.

 New root referenced patch to follow, thanks for your time.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16365#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software