[wp-trac] [WordPress Trac] #16365: Comment transition for new comments

[WordPress Trac]

#16365: Comment transition for new comments
-------------------------+-----------------------------
 Reporter:  MattyRob     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Comments     |     Version:  3.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------------

Comment (by nacin):

 Replying to [comment:7 MattyRob]:
 > I can see it's marked as a future release; it has been for 3 months.
 It's had a patch that works for 4 months and it's a single line change!

 No one noticed a valid patch until after feature freeze. So it needs to
 wait.

 > I know the core devs are busy but honestly when someone contributes code
 that improves the core you really know how to ignore people on here!

 This is one of more than two thousand tickets. I alone make somewhere
 around 600 comments a month to Trac. It's not like I'm deliberately
 avoiding your patches.

 > What about 3.3 then?

 Sure, maybe.

 > How? Not sure what you mean. And is it likely to make any difference to
 the speed it gets committed?

 Yes, actually. There's at least three different comment.php files. Which
 one is this? I'm not inclined to guess. Diff from the root, rather than
 from the directory.

 So here's why I said maybe regarding 3.3, and definite no regarding 3.2:
 I'm not sure I like it. wp_transition_comment_status() is for
 transitioning a comment status from one to another, not for the comment
 creation to begin with. This might cause backwards compatibility issues
 due to the generic hooks in wp_transition_comment_status(). It should
 possibly be a new hook.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16365#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software