[wp-trac] [WordPress Trac] #16839: Category Base Should be Slugified

[WordPress Trac]

#16839: Category Base Should be Slugified
-----------------------------------+-----------------------------
 Reporter:  miklb                  |       Owner:
     Type:  defect (bug)           |      Status:  reviewing
 Priority:  normal                 |   Milestone:  Future Release
Component:  Rewrite Rules          |     Version:  3.1
 Severity:  normal                 |  Resolution:
 Keywords:  3.2-early needs-patch  |
-----------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch 3.2-early => 3.2-early needs-patch


Comment:

 Stumbled upon this while debugging #15256.

 [attachment:16839.2.diff] works with the example of "Foo Bar". However
 using Cyrillic characters in category base gives some strange results.

 Currently Cyrillic category base is not urlencoded, but seems to work in
 most places, except for canonical redirect (where it's just cut, resulting
 in incorrect URL).

 With [attachment:16839.2.diff], "рубрика" is correctly sanitized to
 `%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0`, however any category request
 returns *all* published posts.

 This is what Debug Bar shows:

 Request:[[BR]]
 `%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0/gallery`

 Matched Rewrite Rule:[[BR]]
 `%d1%80%d1%83%d0%b1%d1%80%d0%b8%d0%ba%d0%b0/(.+?)/?$`

 Matched Rewrite Query:[[BR]]
 %d1%gallery&%d1%&%d0%&%d1%&%d0%&%d0%&%d0%&category_name=

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16839#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software