[wp-trac] [WordPress Trac] #11644: multiple blogs & sites / merge WPMU

[WordPress Trac]

#11644: multiple blogs & sites / merge WPMU
----------------------------+-----------------------------------------------
 Reporter:  hakre           |       Owner:  wpmuguru 
     Type:  task (blessed)  |      Status:  assigned 
 Priority:  normal          |   Milestone:  3.0      
Component:  Multisite       |     Version:           
 Severity:  normal          |    Keywords:  multisite
----------------------------+-----------------------------------------------

Comment(by nacin):

 I had said:
 > That said, now that I think about it this would affect any filters being
 applied when get_site_option() is called in ms_network_settings(). So
 maybe we should keep it and somehow clean up the code duplication.
 Since ms_network_settings() checks if $current_site->site_name is set
 first, and we already set that in ms-settings.php, then removing it won't
 affect plugins. It looks like we're just yanking duplicate code that was a
 byproduct of the merge.

 [attachment:11644.10.diff] has a few more improvements over patch 9. It
 also takes some huge hacks away at wpmu_current_site(), though logic will
 need to be double-checked. (I'm also not sure why we might be returning an
 empty $current_site if WP_INSTALLING, as we don't properly handle a
 potentially empty return value in ms-settings.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11644#comment:132>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software