[wp-trac] [WordPress Trac] #11644: multiple blogs & sites / merge WPMU
WordPress Trac
wp-trac at lists.automattic.com
Fri Jan 29 20:18:42 UTC 2010
#11644: multiple blogs & sites / merge WPMU
----------------------------+-----------------------------------------------
Reporter: hakre | Owner: wpmuguru
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 3.0
Component: Multisite | Version:
Severity: normal | Keywords: multisite
----------------------------+-----------------------------------------------
Comment(by nacin):
[attachment:11644.9.diff] removes ms_network_settings(), as all it set was
the current site's name. This was already being done near the end of ms-
settings.php using nearly the same code.
The patch moves down a call to get_current_site_name() in ms-settings.php
by a few lines. That was because I had hoped to use the API in
get_current_site_name(), but since the plugin API isn't loaded yet, we
can't call get_site_option() (which needs $wpdb->siteid to be set, hence
the move). It doesn't need to be moved.
That said, now that I think about it this would affect any filters being
applied when get_site_option() is called in ms_network_settings(). So
maybe we should keep it and somehow clean up the code duplication.
Patch also adds inline docs, plus gettext to is_installed(), and some
other cleanups.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/11644#comment:131>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list