[wp-trac] [WordPress Trac] #11881: setup-config.php step 2 broken

[WordPress Trac]

#11881: setup-config.php step 2 broken
-----------------------------+----------------------------------------------
 Reporter:  sivel            |       Owner:           
     Type:  defect (bug)     |      Status:  new      
 Priority:  normal           |   Milestone:  3.0      
Component:  Upgrade/Install  |     Version:  3.0      
 Severity:  major            |    Keywords:  has-patch
-----------------------------+----------------------------------------------
Changes (by westi):

 * cc: westi (added)


Comment:

 Looking good to me.

 I think I would rename a few of the new functions but I can do that after
 the patch lands.

 I would probably split the default constants function into one function
 for each time it is called as well as the switch is unnecessary.

 I'll look at both of these after it lands in the review and improve phase.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11881#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software