[wp-trac] [WordPress Trac] #11881: setup-config.php step 2 broken

[WordPress Trac]

#11881: setup-config.php step 2 broken
-----------------------------+----------------------------------------------
 Reporter:  sivel            |       Owner:           
     Type:  defect (bug)     |      Status:  new      
 Priority:  normal           |   Milestone:  3.0      
Component:  Upgrade/Install  |     Version:  3.0      
 Severity:  major            |    Keywords:  has-patch
-----------------------------+----------------------------------------------

Old description:

> setup-config.php step 2 is broken now that wp-db.php calls
> is_multisite(). In addition it also causes a notice.
>
> {{{
> Notice: Use of undefined constant WP_DEBUG - assumed 'WP_DEBUG' in
> /var/www/trunk/wp-includes/wp-db.php on line 370
>
> Fatal error: Call to undefined function is_multisite() in /var/www/trunk
> /wp-includes/wp-db.php on line 373
> }}}
>
> Because setup-config.php uses wp-db.php without first including wp-
> settings.php which is where WP_DEBUG and is_multisite are defined it
> causes a notice and a fatal error.

New description:

 11881.5.diff tested ok with my installs.

--

Comment(by wpmuguru):

 Replying to [comment:23 nacin]:
 > I have questions about two variables losing global scope and whether we
 need to globalize them:
 >
 >  - {{{$mu_plugins}}}, an array of PHP files from the must use plugins
 folder. We unset the corresponding array holding plain WP plugins to
 include. It is used nowhere in core and I highly doubt it needs to remain
 a global.
 >
 >  - {{{$prefix}}}, as in {{{$prefix =
 $wpdb->set_prefix($table_prefix);}}} -- which is then checked for
 is_wp_error().
 >
 > I think the answer to both is no (just being cautious), in which case
 [attachment:11881.5.diff] is good on my end.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11881#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software