[wp-trac] [WordPress Trac] #11881: setup-config.php step 2 broken

[WordPress Trac]

#11881: setup-config.php step 2 broken
-----------------------------+----------------------------------------------
 Reporter:  sivel            |       Owner:     
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.0
Component:  Upgrade/Install  |     Version:  3.0
 Severity:  major            |    Keywords:     
-----------------------------+----------------------------------------------

Comment(by westi):

 I think it is worth being more brutal on wp-settings.php and trying to
 move more into file(s) in wp-includes.

 I am also wondering about stuff like:

 {{{
 if ( version_compare( $required_php_version, phpversion(), '>' ) )
     die( sprintf( /*WP_I18N_OLD_PHP*/'Your server is running PHP version
 %s$1 but WordPress requires at least %1$2.'/*/WP_I18N_OLD_PHP*/,
 phpversion(), $required_php_version ) );
 }}}

 and

 {{{
 if ( file_exists(ABSPATH . '.maintenance') &&
 !defined('WP_INSTALLING') )
     wp_maintenance();
 }}}

 I think these would be better as functions we call like
 {{{require_wp_db()}}} is.

 The idea would be to make the top-level code flow down to the wp() call at
 the bottom much more readable.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11881#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software