[wp-trac] [WordPress Trac] #14726: PHPDoc @license Tag Review

[WordPress Trac]

#14726: PHPDoc @license Tag Review
--------------------------+-------------------------------------------------
 Reporter:  hakre         |       Owner:                 
     Type:  defect (bug)  |      Status:  new            
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:  3.0.1          
 Severity:  normal        |    Keywords:  has-patch      
--------------------------+-------------------------------------------------

Comment(by hakre):

 Replying to [comment:2 jacobsantos]:
 > Second patch looks good except for a few issues:
 >
 >  * Added subpackage to PemFTP files, and I suppose to fix the Pure class
 and the Socket class from not showing up in nightlies. The fix for this is
 simple without adding subpackage and should be fixed in a new ticket.

 I don't understand what that means, but if it's easy to fix, good :)

 >  * The patch is dirty in some places making changes not related to the
 {{{@license}}} phpdoc tag. Some examples include the UTF8 translation to
 ANSI function.

 Do you mean character encoding in {{{/wp-includes/class-snoopy.php}}} /
 {{{_striptext()}}} line 720 and something?

 >  * Patch doesn't appear to be accepted format for which Trac can read.
 I'm not sure why this is, but it would be helpful.

 Patch does exploit tracs display, [http://trac.edgewall.org/ticket/9590 I
 reported it upstream].

 Thanks for the review, please let me know for the other two points. with
 the encoding of the snoopy class it looks like that those values need to
 be properly encoded in the PHP code instead of just putting them in. I
 think the changes happens on my side becaue I checkout the whole project
 as UTF-8.

 Do you have the binary values that are used in there? Maybe that is
 exploiting the trac display as well? Should we create another ticket to
 just fix the encoding issue in the snoopy class so we get it ASCII-7BIT
 save?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14726#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software