[wp-trac] [WordPress Trac] #14726: PHPDoc @license Tag Review
WordPress Trac
wp-trac at lists.automattic.com
Sun Aug 29 23:48:41 UTC 2010
#14726: PHPDoc @license Tag Review
--------------------------+-------------------------------------------------
Reporter: hakre | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.0.1
Severity: normal | Keywords: has-patch
--------------------------+-------------------------------------------------
Comment(by jacobsantos):
Second patch looks good except for a few issues:
* Added subpackage to PemFTP files, and I suppose to fix the Pure class
and the Socket class from not showing up in nightlies. The fix for this is
simple without adding subpackage and should be fixed in a new ticket.
* The patch is dirty in some places making changes not related to the
{{{@license}}} phpdoc tag. Some examples include the UTF8 translation to
ANSI function.
* Patch doesn't appear to be accepted format for which Trac can read. I'm
not sure why this is, but it would be helpful.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/14726#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list