[wp-trac] [WordPress Trac] #13058: Feed link not working with non-category taxonomy in wp_list_categories()

WordPress Trac wp-trac at lists.automattic.com
Sun Apr 25 19:09:24 UTC 2010


#13058: Feed link not working with non-category taxonomy in wp_list_categories()
--------------------------+-------------------------------------------------
 Reporter:  greenshady    |       Owner:                         
     Type:  defect (bug)  |      Status:  new                    
 Priority:  normal        |   Milestone:  3.0                    
Component:  Feeds         |     Version:  3.0                    
 Severity:  normal        |    Keywords:  has-patch needs-testing
--------------------------+-------------------------------------------------
Changes (by blepoxp):

  * keywords:  needs-patch => has-patch needs-testing


Comment:

 Ok,
 13058-2.diff cleans up the coding standards, removes the diff on
 xmlrpc.php and compensates for custom query_vars in custom taxonomies.

 The patch actually worked ok for determining whether to use custom rewrite
 rules or not. Consensus in wordpress-dev was that custom rewrite rules for
 custom taxonomies should not be used if default permalinks are selected in
 admin GUI. This was actually working.

 What wasn't working was the scenario where default permalinks are selected
 in the admin GUI and a custom query_var had been registered for the custom
 taxonomy. I have modified the code to compensate for this.

 I looked over http://codex.wordpress.org/WordPress_Coding_Standards and
 modified my code accordingly. Please let me know if I misread any of the
 standards.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13058#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list