[wp-trac] [WordPress Trac] #13058: Feed link not working with non-category taxonomy in wp_list_categories()

[WordPress Trac]

#13058: Feed link not working with non-category taxonomy in wp_list_categories()
--------------------------+-------------------------------------------------
 Reporter:  greenshady    |       Owner:             
     Type:  defect (bug)  |      Status:  new        
 Priority:  normal        |   Milestone:  3.0        
Component:  Feeds         |     Version:  3.0        
 Severity:  normal        |    Keywords:  needs-patch
--------------------------+-------------------------------------------------
Changes (by dd32):

  * keywords:  has-patch needs-testing => needs-patch


Comment:

 Patch review:
  * xmlrpc.php change is not needed, get_category_link() doesnt have a 3rd
 arg.
  * Should check if the taxonomy has rewrite enabled, ie. get the taxonomy
 permastruct, not the general permastruct, Its possible to register a
 taxonomy which does not use the inbuilt rules, those taxonomies will need
 to filter this function if they have a special structure.
  * @package isnt needed for function-level documentation, leave that for
 the file-level documentation
  * Coding standards:
 {{{
  if ( Something )
     // do something
  else
     // do something else
 }}}
    * Spaces around language structs (if)
    * Spaces around conditionals
    * Skip the {'s if its only a single line
    * Spaces around concatenation ( {{{something".$var."=}}}  vs
 {{{something" . $var . "=}}}

 Patch looks good otherwise, most of those are things i'd change upon
 commit, but thought i'd give a review since the rewrite code will need
 updating.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13058#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software