[wp-trac] Re: [WordPress Trac] #10011: Use of add_theme_page() causes Wordpress on IIS to crash.

[WordPress Trac]

#10011: Use of add_theme_page() causes Wordpress on IIS to crash.
-------------------------------+--------------------------------------------
 Reporter:  bforchhammer       |        Type:  defect (bug)
   Status:  new                |    Priority:  normal      
Milestone:  2.9                |   Component:  Plugins     
  Version:  2.7.1              |    Severity:  major       
 Keywords:  needs-patch early  |  
-------------------------------+--------------------------------------------

Comment(by bforchhammer):

 Replying to [comment:25 dd32]:
 > So the solution here, seems to be to replace plugin_basename($file) with
 {{{theme_basename(plugin_basename($file))}}} in all of the add-menu calls
 IMO.

 Sounds good to me.

 That would probably not change anything in the current behaviour; as far
 as I can see the full path is not used for anything else but the "action
 hook name" at the moment so it shouldn't break anything... (?)

 If I read the code correctly it should probably also be possible to point
 the path to a different file instead of using a function callback for the
 menu item; the last parameter in `add_submenu_page()` seems optional.


 > Mind you, Thats going to require some testing(And given 2.8's nearing
 release), I'd suggest that this gets delayed to early 2.9 to allow for
 some proper testing?

 Fine by me :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10011#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software