[wp-trac] Re: [WordPress Trac] #10011: Use of add_theme_page() causes Wordpress on IIS to crash.

WordPress Trac wp-trac at lists.automattic.com
Sat Jun 6 07:23:05 GMT 2009


#10011: Use of add_theme_page() causes Wordpress on IIS to crash.
-------------------------------+--------------------------------------------
 Reporter:  bforchhammer       |        Type:  defect (bug)
   Status:  new                |    Priority:  normal      
Milestone:  2.9                |   Component:  Plugins     
  Version:  2.7.1              |    Severity:  major       
 Keywords:  needs-patch early  |  
-------------------------------+--------------------------------------------
Changes (by dd32):

  * keywords:  needs-patch => needs-patch early
  * milestone:  2.8 => 2.9


Comment:

 You're right... that would work just as well.

 i'm not too sure it matters about other parts of WordPress expecting those
 parts to be relative to the plugins directory, The chances of a plugin of
 the same name with a file called 'functions.php' is incredibly unlikely.
 Furthurmore, I think that the hookname would still be reconised correctly.

 So the solution here, seems to be to replace plugin_basename($file) with
 {{{theme_basename(plugin_basename($file))}}} in all of the add-menu calls
 IMO.

 Mind you, Thats going to require some testing(And given 2.8's nearing
 release), I'd suggest that this gets delayed to early 2.9 to allow for
 some proper testing?

 If someone thinks of a better way thats absolutely 100% backwards
 compatible.. then speak up..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10011#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list