[wp-trac] [WordPress Trac] #8833: extract pluggable.php function logic into separate functions

WordPress Trac wp-trac at lists.automattic.com
Mon Jul 13 22:49:00 UTC 2009


#8833: extract pluggable.php function logic into separate functions
-------------------------+--------------------------------------------------
 Reporter:  wnorris      |       Owner:  Viper007Bond                  
     Type:  enhancement  |      Status:  new                           
 Priority:  normal       |   Milestone:  Future Release                
Component:  Plugins      |     Version:  2.8                           
 Severity:  normal       |    Keywords:  needs-patch dev-feedback close
-------------------------+--------------------------------------------------

Comment(by azaozz):

 The original idea is good and 8833.2.patch looks good. However I'm not
 sure how the filter based replacements would behave when there are several
 plugins using them.

 Currently when two or more plugins try to replace the same pluggable
 function the first one "wins" (and keeps working) and the second fails. If
 we add something like 8833.2.patch, the second would be able to use the
 default function and still work in most cases. However if we pass filtered
 values from one plugin to the other chances are that both would fail for
 some functions.

 IMHO switching from !function_exists() to add_filter()/add_action() would
 require a lot of testing both as a usable solution and for regressions
 /back-compat and would break some plugins.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/8833#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list